This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the standard claims parser is invalid. It doesn't allow
NumericDate
value to be floats, while it's explicitly allowed by the RFC:(Emphasis mine).
This is annoying because popular libraries generate tokens containing floats in the
exp
,iat
andnbf
fields. For intstance, it's the case oflcobucci/jwt
, one of the most popular JWT library written in PHP.This PR fixes this, and also allows comparing fractions of seconds.
This is a BC break, so it should be merged in the 4.0 version.
Closes dunglas/mercure#404.