This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Fix sec vuln with list of claims #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-form3
previously approved these changes
Sep 14, 2020
wojciecholszewski-form3
previously approved these changes
Sep 14, 2020
rkorkosz
suggested changes
Sep 14, 2020
Waterdrips
dismissed stale reviews from wojciecholszewski-form3 and leo-form3
via
f8fbdb3
rkorkosz
approved these changes
Sep 14, 2020
wojciecholszewski-form3
previously approved these changes
Sep 14, 2020
rkorkosz
previously approved these changes
Sep 14, 2020
|
Travis is having issues building the branch. Is it maybe because you are creating a PR from your private repo? |
Signed-off-by: Alistair Hey <alistair.hey@form3.tech>
Signed-off-by: Alistair Hey <alistair.hey@form3.tech>
Signed-off-by: Alistair Hey <alistair.hey@form3.tech>
Signed-off-by: Alistair Hey <alistair.hey@form3.tech>
Waterdrips
dismissed stale reviews from rkorkosz, owenrumney, and wojciecholszewski-form3
via
4ea2e3f
Waterdrips
force-pushed
the
waterdrips-fix-security-vuln
branch
from
f8fbdb3
to
4ea2e3f
Compare
owenrumney
approved these changes
Sep 14, 2020
wojciecholszewski-form3
approved these changes
Sep 14, 2020
|
close and re-open to try and get rid of duplicate travis PR checks |
|
going to re-open a new pr to try and fix the duplicate checks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Security Vuln in v 3.2.0 with invalid check on "aud" claim when claim is a list of strings (RFC states it should be list of strings, or in special case a String only)
Signed-off-by: Alistair Hey alistair@heyal.co.uk