Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub-side reference counting #22

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Stub-side reference counting #22

merged 2 commits into from
Jul 8, 2024

Conversation

joaomhmpereira
Copy link
Member

No description provided.

@joaomhmpereira joaomhmpereira linked an issue Jul 8, 2024 that may be closed by this pull request
@filipeom
Copy link
Member

filipeom commented Jul 8, 2024

Looks good to me.

Btw, are you not following the rules of CAMLparam, CAMLlocal, and CAMLreturn from https://ocaml.org/manual/5.2/intfc.html#ss:c-simple-gc-harmony?

I think in most cases it's probably safe to omit it because we're not doing any more custom block allocations that we don't always return. But maybe you could do this in a separate PR? To prevent breaking things in the future? The overhead of doing this won't be significant

@joaomhmpereira
Copy link
Member Author

joaomhmpereira commented Jul 8, 2024

I think in most cases it's probably safe to omit it because we're not doing any more custom block allocations that we don't always return. But maybe you could do this in a separate PR? To prevent breaking things in the future? The overhead of doing this won't be significant

Yes, I'll implement this in a future PR (addressed in #24)

@joaomhmpereira joaomhmpereira merged commit 3becf5d into main Jul 8, 2024
2 checks passed
@joaomhmpereira joaomhmpereira deleted the stub-side-rc branch July 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stub-side reference counting
2 participants