-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] CI and Public library #5
Conversation
I'll leave this issue here as I think it might be relevant to me ocaml/dune#4409 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, can you add some ocamlformat configuration to the project and run dune fmt
? Just so things are a bit more consistent
I recommend https://github.com/formalsec/encoding/blob/main/.ocamlformat but you can choose whatever you like most
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the help @filipeom!
Merging!
This is a work in progress. Currently, my build is failing to install due to these errors:
Current problems
It seems to be complaining that
cvc5_export.h
doesn't exist. Maybe I'm missing some include?Public library
Also, when I made the
cvc5
library public (with thepublic_name cvc5
) it seems that is it also raising new errors complaining about missing shared libraries:This second problem seems to be more problematic, as using
./configure.sh
with--static
will only generate static library archives (i.e.,.a
) and using the configuration script without--static
only generates shared library archives (i.e.,.so
) there's no option to use configure to generate both.