Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subcommands and man pages #15

Merged
merged 10 commits into from
Mar 4, 2024
Merged

Add subcommands and man pages #15

merged 10 commits into from
Mar 4, 2024

Conversation

julianayang777
Copy link
Contributor

@julianayang777 julianayang777 commented Mar 4, 2024 •
edited
Loading

Change the command line interface:

  • Executing a single program:
    • Before: wl
    • Now: wl execute
  • Executing all programs in the directory
    • Before: test_wl
    • Now: wl test

Additionally, there is a man page for each command.
The description might not be the best, feel free to modify😁.

@julianayang777 julianayang777 requested a review from filipeom March 4, 2024 11:12
filipeom
filipeom requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@filipeom filipeom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a high-level view of the code. And I think we can improve the way we handle the mode argument. I left some comments. Later today I'll checkout the branch and the tool to see how it feels :)

bin/commands/cmd_execute.ml Outdated Show resolved Hide resolved
bin/commands/cmd_test.ml Outdated Show resolved Hide resolved
bin/utils/options.ml Outdated Show resolved Hide resolved
@julianayang777 julianayang777 merged commit b009321 into main Mar 4, 2024
2 checks passed
@julianayang777 julianayang777 deleted the commands branch March 4, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipeom filipeom filipeom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianayang777 @filipeom