Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ledger): fix panic when checking last log #470

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

paul-nicolas
Copy link
Contributor

@paul-nicolas paul-nicolas commented Oct 26, 2023

Fixes ENG-174

@paul-nicolas paul-nicolas changed the base branch from main to release/v1.10 October 26, 2023 13:08
@paul-nicolas paul-nicolas changed the title Fix/panic post transaction fix(ledger): fix panic when checking last log Oct 26, 2023
@paul-nicolas paul-nicolas marked this pull request as ready for review October 26, 2023 13:09
@paul-nicolas paul-nicolas requested a review from a team October 26, 2023 13:15
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93ed88f) 64.08% compared to head (6485bb9) 64.08%.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/v1.10     #470   +/-   ##
==============================================
  Coverage          64.08%   64.08%           
==============================================
  Files                152      152           
  Lines              14154    14154           
==============================================
  Hits                9071     9071           
  Misses              4492     4492           
  Partials             591      591           
Files Coverage Δ
pkg/storage/sqlstorage/transactions.go 78.60% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paul-nicolas paul-nicolas merged commit fcdd62d into release/v1.10 Oct 26, 2023
20 checks passed
@paul-nicolas paul-nicolas deleted the fix/panic-post-transaction branch October 26, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants