fix: failing queries (GET /accounts?expand=volumes) when migrations are not terminated

[gfyrag]

No description provided.

[coderabbitai]

Walkthrough

The pull request updates several configuration and migration files. In the .gitignore, a new rule was added to ignore any YAML files matching Pulumi.*.yaml while ensuring that the .envrc file remains tracked. Both the main Earthfile and its counterpart in the generator are updated to reference the newer core version (v0.19.1). Additionally, the migration script in the internal storage module now defines several new SQL functions to address search path issues on older databases.

Changes

File	Change Summary
.gitignore	Added entry Pulumi.*.yaml; retained exception !.envrc
Earthfile tools/.../Earthfile	Updated import statement for the core module from version v0.19.0 to v0.19.1
internal/.../up.sql	Added new SQL functions: get_transaction, get_all_assets, get_account_aggregated_effective_volumes, and get_account_aggregated_volumes with search path adjustments

Suggested reviewers

• paul-nicolas

Poem

In my coding burrow I happily roam,
New rules and functions now make my home.
YAMLs hide away, while Earthfiles gleam,
SQL tunes and tweaks join the dream.
Hop along and code on—joy flows like a stream! 🐰

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (28fa6b4) to head (ce625fd).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   81.97%   81.82%   -0.16%     
==========================================
  Files         135      135              
  Lines        7291     7291              
==========================================
- Hits         5977     5966      -11     
- Misses       1008     1016       +8     
- Partials      306      309       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

internal/storage/bucket/migrations/11-make-stateless/up.sql (2)

580-601: Consider adding volatility qualifier to get_all_assets function

The function is properly implemented with the search path fix, but unlike other functions, it doesn't have an explicit volatility qualifier (like stable or immutable). Since this function doesn't modify the database and would return the same results for the same parameters, consider adding a stable qualifier.

create or replace function get_all_assets(_ledger varchar)
	returns setof varchar
+	stable
	language sql
as

---

603-612: Consider adding parallel safe attribute for consistency

The function get_account_aggregated_volumes has the parallel safe attribute, but this one doesn't. If this function can also be safely executed in parallel, consider adding this attribute for consistency and potential performance benefits.

create or replace function get_account_aggregated_effective_volumes(_ledger varchar, _account_address varchar,
                                                         _before timestamp default null)
	returns jsonb
	language sql
	stable
+	parallel safe
as

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28fa6b4 and ce625fd.

📒 Files selected for processing (4)

• .gitignore (1 hunks)
• Earthfile (1 hunks)
• internal/storage/bucket/migrations/11-make-stateless/up.sql (2 hunks)
• tools/generator/Earthfile (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• tools/generator/Earthfile

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Tests

🔇 Additional comments (5)

.gitignore (1)

10-11: LGTM: Version control configuration updates are appropriate

The changes to the .gitignore file look good:

1. Retaining !.envrc ensures that this environment configuration file remains tracked in the repository
2. Adding Pulumi.*.yaml to ignore Pulumi configuration files is appropriate as these often contain environment-specific settings

Earthfile (1)

4-4: Dependency update from v0.19.0 to v0.19.1 is appropriate

This is a minor version update of the core dependency, which follows semantic versioning principles and should be backward compatible.

internal/storage/bucket/migrations/11-make-stateless/up.sql (3)

562-564: Good documentation for the search path fix

The comments clearly explain the purpose of the changes - recreating functions with proper search path configuration for databases created before version 2.2.

---

565-578: Function definition looks good with search path fix

The get_transaction function is properly defined with the set search_path from current; statement to fix the search path issue on older databases.

---

614-623: Function definition with parallel safe attribute looks good

The get_account_aggregated_volumes function is properly defined with both stable and parallel safe attributes, along with the search path fix.