IntlProvider formats & defaultFormats seem broken in latest release (3.3.2).

[zjr]

Expected behavior

Using formats & defaultFormats should allow printing formatted messages with custom formats.

<IntlProvider . . . defaultFormats={{ date: { 'short-weekday': { weekday: 'short' } } }} . . ./>

Should allow message with "The day is {monday, date, short-weekday}." to render as "The day is Mon."

Current behavior

Instead formats and defaultFormats do nothing and date is rendered with default format (e.g. "The day is 10/14/2019."

I have verified that this all works if I downgrade version to 3.0.0, have not yet tested other versions.

Step to reproduce for BUG REPORT

Use IntlProvider wherever, define a defaultFormats, try to use that in a FormattedMessage within/using the provider. Doesn't matter if injected or through hook or just nested.

Your Environment

Executable	Version
npm ls react-intl	3.3.2
npm ls react	16.9.0
npm --version	yarn 1.19.1
node --version	12.11.1

OS	Version
macOS Catalina	10.15

Browser	Version
Chrome	77.0.3865.90

[zjr]

After further testing it seems this issue was in fact introduced in the 3.3.2 release, 3.3.1 works as expected.

[longlho]

Do you have a codesandbox?

…

On Mon, Oct 14, 2019, 2:34 AM Zachary J. Rollyson ***@***.***> wrote: After further testing it seems this issue was in fact introduced in the 3.3.2 release, 3.3.1 works as expected. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1500>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABQM36OML7QP2VYD256OYLQONZ5XANCNFSM4JAHR5NQ> .

[zjr]

No and I'm not generally aware of a handy way to sandbox react-intl. I can tell you that after installing every version of the package since 3.0.0, 3.3.1 3.3.2 is the only version with an issue. If I have some more time later I will try to figure out how to get this package into a sandbox.

Edit: corrected version

[longlho]

I mean codesandbox.io link to repro this

…

On Mon, Oct 14, 2019 at 6:51 AM Zachary J. Rollyson < ***@***.***> wrote: No and I'm not generally aware of a handy way to sandbox react-intl. I can tell you that after installing every version of the package since 3.0.0, 3.3.1 is the only version with an issue. If I have some more time later I will try to figure out how to get this package into a sandbox. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1500>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABQM33HAGN24C5L5FTXHTLQOOYBZANCNFSM4JAHR5NQ> .

[zjr]

Here you go…

this is with v3.3.2, broken: https://codesandbox.io/s/focused-leakey-46yr4
here is with v3.3.1, works: https://codesandbox.io/s/blissful-zhukovsky-9oq4w

[longlho]

Thanks I'll take a look next week when I'm back from vacation

…

On Mon, Oct 14, 2019, 8:23 AM Zachary J. Rollyson ***@***.***> wrote: Here you go… this is with v3.3.2, broken: https://codesandbox.io/s/focused-leakey-46yr4 here is with v3.3.1, works: https://codesandbox.io/s/blissful-zhukovsky-9oq4w — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1500>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABQM33EJ2SADZNIPNJOBF3QOPCZTANCNFSM4JAHR5NQ> .