This repository has been archived by the owner on May 23, 2019. It is now read-only.
Icu formatters #36
Merged
Icu formatters #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,12 +236,12 @@ | |||
| this.pattern = pattern; | |||
|
|
|||
| // store formatters | |||
| this.formatters = {}; | |||
| this.formatters = DEFAULT_FORMATTERS; | |||
There was a problem hiding this comment.
DEFAULT_FORMATTERS is a class level structure, and optFieldFormatters is an instance level structure. We could use prototype chain here to make sure that an instance is not going to modify the default formatters:
this.formatters = optFieldFormatters || {};
this.formatters.__proto__ = DEFAULT_FORMATTERS;
the rest is not needed. In the case of the custom_ this is really not necessary because that type does not exists.
…call it and it does not work, they can fix it.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ICU Formatters as a protected object so overrides are not available as they wouldn't be available in the Intl.MessageFormat