Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): vertical label bg #23

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

yee94
Copy link
Collaborator

@yee94 yee94 commented Jul 26, 2023

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or master.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

  • fix the vertical label
  • remove the error bg color

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for formily-antd5 ready!

Name Link
🔨 Latest commit ba5d2bb
🔍 Latest deploy log https://app.netlify.com/sites/formily-antd5/deploys/64c132d2e152850008e9f22c
😎 Deploy Preview https://deploy-preview-23--formily-antd5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yee94 yee94 merged commit 64e9c0a into formilyjs:master Jul 26, 2023
@yiyunwan
Copy link
Member

我看colorErrorBg都删掉了,是什么原因呢?

@yee94
Copy link
Collaborator Author

yee94 commented Aug 16, 2023

Antd 5 的设计中没有这个背景颜色的 TOKEN,这里的样式设置会导致 Formily 的表单与 antd 的 Form 有差异。可以看看是否可以通过 antd 的 PR 先支持这个 TOKEN 后再 follow 改动

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants