Skip to content

Conversation

travist
Copy link
Member

@travist travist commented Jan 6, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9547

Description

This PR upgrades the @formio/angular library to work with Angular 19. The biggest change was that the "standalone" flag now defaults to "true" so for all the components, we need to provide that flag and set it to false.

Breaking Changes / Backwards Compatibility

None.

Dependencies

How has this PR been tested?

We will be upgrading all our internal applications and modules to depend no this upgrade.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like an angular dependency (glob) doesn't support node < 20, although angular claims that 18 is actively supported. Is this going to be an issue for developer customers? I can easily upgrade the CI runner to 20, but I just wanted to check if there's something we need to be doing differently here.

@brendanbond brendanbond merged commit b5e68c0 into master Feb 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants