FIO-4816: fixed email submission: data display issues #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travist
reviewed
May 9, 2023
travist
reviewed
May 9, 2023
travist
reviewed
May 9, 2023
travist
requested changes
May 9, 2023
…ail-submission-data-display-issues
TanyaGashtold
approved these changes
Sep 21, 2023
lane-formio
pushed a commit
that referenced
this pull request
Sep 26, 2023
* FIO-4816: fixed email submission: data display issues * corrected some points and added tetst * FIO-4816: fixed tests * fixed incorrect rebase issue * fixed test * fix test styles --------- Co-authored-by: AlexanderLihodievskiy <alexandrel@form.io> Co-authored-by: Travis Tidwell <travis@form.io> Co-authored-by: TanyaGashtold <61136841+TanyaGashtold@users.noreply.github.com> Co-authored-by: ICX\Tatsiana.Hashtold <tanya@form.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-4816
Description
What changed?
Changed the methods that are responsible for rendering the sent form in the mail
Why have you chosen this solution?
Worked with the "getValueAsString" method. Because it allows you to change the rendering of form components in the mail
Dependencies
This PR does not depends on the following PRs from other Form.io modules: ...
How has this PR been tested?
I added automated tests to cover all cases
Checklist: