Skip to content

Conversation

@TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Dec 6, 2023

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7588

Description

What changed?

  • before string value for Survey looked like stringified object, changed it so that it looks like as string with question and answer labels separated by ";"
    Before: {"quest1":"b","quest2":"a"}
    Now: 'Question 1: B; Question 2: A'
  • modified asString method of select component, so that in case of csv option, it returns plain text without HTML
  • fixed updateRenders method as before it does not update all renders due to wrong directory.
  • added/modified tests

Dependencies

https://github.com/formio/reporting/pull/13

How has this PR been tested?

Manually + tests

All tests passed locally!!!

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist travist merged commit c9431f3 into master Dec 7, 2023
lane-formio pushed a commit that referenced this pull request Dec 7, 2023
* FIO-7588: fixed string value for Survey and Select

* fixed render tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants