Fixed an issue where the 'root' may be the component that does not have a getComponent method. #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve a getComponent method.
johnformio
reviewed
Jul 3, 2024
Comment on lines
27
to
31
| let conditionTriggerComponent = null; | ||
|
|
||
| if (instance && instance.root) { | ||
| if (instance?.root?.getComponent) { | ||
| conditionTriggerComponent = instance.root.getComponent(conditionComponentPath); | ||
| } |
There was a problem hiding this comment.
You can use optional chaining on functions as well.
let conditionTriggerComponent = instance?.root?.getComponent?.(conditionalComponentPath)
johnformio
approved these changes
Jul 3, 2024
johnformio
approved these changes
Sep 10, 2024
lane-formio
pushed a commit
that referenced
this pull request
Sep 10, 2024
…ve a getComponent method. (#5673)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://formio.atlassian.net/browse/FIO-8802
Description
The tests in formio CSVExporter are failing because it creates the components with Component.create(). The issue is that this will crash if the component has a simple conditional since the component does not have a method getComponent.
Checklist: