Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8556: Test coverage metrics #5755

Merged
merged 9 commits into from
Sep 17, 2024
Merged

Conversation

mikekotikov
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8556

Description

What changed?

Added tests coverage with nyc library

Dependencies

None

How has this PR been tested?

Manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio
Copy link
Contributor

johnformio commented Aug 16, 2024

@mikekotikov the build failed. Your coverage thresholds are too high. You will need to set these after you run coverage the first time to know what the initial settings should be.

ERROR: Coverage for lines (15.86%) does not meet global threshold (80%)
ERROR: Coverage for functions (15.33%) does not meet global threshold (79%)
ERROR: Coverage for branches (19.05%) does not meet global threshold (63%)
ERROR: Coverage for statements (15.81%) does not meet global threshold (81%)

@mikekotikov mikekotikov marked this pull request as draft August 19, 2024 11:30
@mikekotikov mikekotikov marked this pull request as ready for review September 9, 2024 12:33
@johnformio johnformio merged commit a58f0cc into master Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants