FIO-9126 fixed display of value for Day component with hidden fields #5838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| day = defaults[DAY] && !_.isNaN(defaults[DAY]) ? defaults[DAY] : 0; | ||
| day = (defaults.length !== 3 && value) ? | ||
| this.getDayWithHiddenFields(defaults).day | ||
| : (defaults[DAY] && !_.isNaN(defaults[DAY]) ? defaults[DAY] : 0); | ||
| } |
There was a problem hiding this comment.
Just a quick note on the code style. In our code we are used to using a bit different style for the ternary operator:
condition
? value1
: value2
Lets keep our code clean and in the same style.
TanyaGashtold
requested changes
Oct 3, 2024
TanyaGashtold
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9126
Description
Fixed the display of the Day component dataValue with hidden fields in the Data tab
Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
Automated tests have been added. All test pass locally
Checklist: