Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIO-9283: fixed na issue where select with resource dataSrc does not display values in readOnly mode #5893

Merged
merged 2 commits into from
Nov 4, 2024
Merged

FIO-9283: fixed na issue where select with resource dataSrc does not display values in readOnly mode #5893

merged 2 commits into from
Nov 4, 2024

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Nov 4, 2024 •
edited
Loading

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9283

Description

What changed?

Do not clean metadata in readOnly

How has this PR been tested?

Manually + tests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold marked this pull request as draft November 4, 2024 08:59
@TanyaGashtold TanyaGashtold marked this pull request as ready for review November 4, 2024 14:18
@johnformio johnformio merged commit 2079440 into master Nov 4, 2024
5 checks passed
lane-formio pushed a commit that referenced this pull request Nov 4, 2024
@TanyaGashtold @lane-formio
FIO-9283: fixed na issue where select with resource dataSrc does not …
12eec3f 
…display values in readOnly mode (#5893)

* FIO-9283: fixed na issue where select with resource dataSrc does not display values in readOnly mode

* fixed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnformio johnformio johnformio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanyaGashtold @johnformio