Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIO-9360: validate current page only on wizard change #5920

Merged
merged 4 commits into from
Nov 25, 2024
Merged

FIO-9360: validate current page only on wizard change #5920

merged 4 commits into from
Nov 25, 2024

Commits on Nov 21, 2024

  1. validate current page on wizard change

    @brendanbond
    brendanbond committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f58ae24 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. add tests

    @brendanbond
    brendanbond committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    144d0c7 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @brendanbond
    brendanbond committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    ec4c1d3 View commit details
    Browse the repository at this point in the history

  3. Specify correct flag for form validation after failed wizard submission 

    - this.validate() is only called in onChange() if the form previously failed to submit. Because of this, the form will already be dirty, so it makes sense to reiterate this by passing dirty: true instead of false.
    @blakekrammes
    blakekrammes committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f1002ff View commit details
    Browse the repository at this point in the history