Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIO-9350 Wizard: Show form-level errors after failed submission on subsequent form interaction when current page has no errors #5922

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

FIO-9350 Wizard: Show form-level errors after failed submission on subsequent form interaction when current page has no errors #5922

wants to merge 5 commits into from
+296 −214

Commits on Nov 25, 2024

  1. FIO-9350 Wizard: Show all form errors consistently after failed submi… 

    …ssion

- Show all form errors on page without required fields after failed submission
- Show all form errors on page with required fields after failed submission and after interacting with the page
    @blakekrammes
    blakekrammes committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d9e1b04 View commit details
    Browse the repository at this point in the history

  2. FIO-9350 Wizard: Persist form errors if submission failed 

    - While showErrors worked as expected (defined in Webform), this.errors (get errors()) in Wizard was not persisting all the form errors after a failed submission
    @blakekrammes
    blakekrammes committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    06ab5e0 View commit details
    Browse the repository at this point in the history

  3. FIO-9350 Wizard: Clean up dup helper fns in tests 

    - Consolidate most link navigation to one global helper fn
    @blakekrammes
    blakekrammes committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6380e84 View commit details
    Browse the repository at this point in the history

  4. FIO-9350 Wizard: Add test for maintaining form errors after failed su… 

    …bmit

- Show form-level errors after failed submission even when the current page has no errors
    @blakekrammes
    blakekrammes committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    34cf9a2 View commit details
    Browse the repository at this point in the history

  5. FIO-9350 Wizard: Simplify async flow for flaky test

    @blakekrammes
    blakekrammes committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    103bd98 View commit details
    Browse the repository at this point in the history