Skip to content

FIO-10109 fixed TextArea Styling for Quick Inline Embed #6120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HannaKurban
Copy link
Contributor

@HannaKurban HannaKurban commented May 15, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-10109

Description

The reason for the issue of broken styles for the TextArea component with editors applied when using a Quick Inline Embed link is that if the Quick Inline Embed link includes libs=true property, then a shadowRoot is created to display the form.
At the same time ShadowRoot does not apply external styles. This issue has been fixed for the ace library using the built-in method. However, since the CKeditor and Quill libraries do not support using in ShadowRoot, the appropriate styles were loaded inside shadowRoot to display the TextArea component correctly.

If the Quick Inline Embed link does not include libs=true , then the entire form is displayed as expected.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

locally using Quick Inline Embed link. All tests pass locally

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant