Update React & one fix #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't realize this file went through a transform and strictmode automatically applied. The JSX at the bottom should have been a dead-giveaway ;P ohwell.. this makes my transformer work by escaping strict mode for the evaluation of the field expressions.
projects that need React 0.13.x, use version 0.3.x. projects that need React 0.14.x or 15.x.x can use >0.4.x
|
Looks good. I knew we had a problem with the "with" line so nice to see a good fix for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have split this into two, but I was already deep in when I noticed the strict mode bug.
I wanted to jump in and update react for you. So this primarily does that.
However, my previous pull request had a hidden bug because all modules are marked strict by default. There is a fix for that in here as well. Once this pull request is merged, I recommend checking out the tag v0.3.0 and testing it through your stack and then publishing it to npm. Then cut a 0.4.0 with the react updates.
The react updates permit React 0.14 and 15.x versions. Giving your component widest possible user base. For projects suck on 0.13 they can continue to use <=0.3 of this component.