-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proposal] add github actions to templates #438
Comments
I think basic issue/PR templates that can then be customized per library would be great (and are often under-prioritized) and are fairly universal too. I'm ambivalent about Actions. I use Travis for my libraries and it's a lot more reliable, readable, and functional than GH (e.g. simple things like restarting a test) and has one-liner code coverage integration. On the one hand, it's much easier to delete stuff than to add stuff, but that can quickly spiral into having too many things to delete. As more stuff gets added to the templates (e.g. actions, storybook, etc), it might make sense to have TSDX wrap more of that functionality internally instead of exposing all the config to users (that would also mean that instead of needing to delete something, you just don't use that functionality, which is even easier). |
Is there a way to do this with some system better than templates? What if I want Storybook TSDX + GitHub Actions? I can easily make a PR for the actions config FWIW, just not sure how to integrate it well as part of the TSDX CLI. |
idk i was thinking just add some files, but come to think about it maybe we want a new |
Do we just wanna add it by default to all templates? |
i think so. i do wanna get a 👍 or 👎 from @jaredpalmer before we proceed brainstorming any further |
Yeah, I would add a workflows to templates. I want to keep the core lean going forward, but I’m open to a new cli command like: tsdx add ... and tsdx remove. This could allow folks to write project manipulations going forward they are standardized |
Okay, cool. For this change of course, it's easy for people to just delete the |
let's get something small in. basic test action? |
I'll get this tomorrow 🕺 |
Current Behavior
gh actions are awesome. lets recommend and auto scaffold some for people to test their tsdx libraries? i know not everybody uses github but they could just delete the .github folder if so.
pull some from https://github.com/sdras/awesome-actions
what actions would people like?
e.g. i'd like matrix testing by default, as well as issue/pr templates
The text was updated successfully, but these errors were encountered: