Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade engines.node to >=12 in package.json for basic template #733

Closed
wants to merge 1 commit into from
Closed

Conversation

zenflow
Copy link

@zenflow zenflow commented May 23, 2020

The engines.node field should match the version of node we are testing against in CI: https://github.com/jaredpalmer/tsdx/blob/21893b8e498985879bb6665dba279cf4853aabec/templates/basic/.github/workflows/main.yml

This change doesn't apply to the other templates

Thanks for the awesome package! You saved me a ton of time for sure! <3

@agilgur5
Copy link
Collaborator

agilgur5 commented May 25, 2020

I appreciate that you were looking for some consistency here, but I'm sorry to say that I'll have to decline the PR in its current state.

The current GitHub Action was meant to just be a starting point and not the end state. The action in each template is also meant to be the same; it's a limitation of our current templating set-up that there are multiple files.

Node 10 is still LTS for another year, until May 2021, so I would certainly not recommend library authors only support Node 12+. It would be better to add matrix testing for different Node versions and OSes like TSDX itself does, which is likely to be added in the near future.
Per the proposal issue #438, the basic variant was meant not to significantly bloat the templates as an initial feature especially as we'd prefer partial scaffold commands that could set-up things like Actions or TravisCI for instance.

@agilgur5 agilgur5 closed this May 25, 2020
@agilgur5 agilgur5 added solution: intended behavior This is not a bug and is expected behavior problem: stale Issue has not been responded to in some time solution: workaround available There is a workaround available for this issue labels Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem: stale Issue has not been responded to in some time solution: intended behavior This is not a bug and is expected behavior solution: workaround available There is a workaround available for this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants