Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @rollup/plugin-commonjs to the latest version 🚀 #727

Closed

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented May 20, 2020


🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io


The dependency @rollup/plugin-commonjs was updated from 11.1.0 to 12.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: shellscape
License: MIT

Find out more about this release.


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@agilgur5
Copy link
Collaborator

Changelog here. It's actually up to v15 now. Doesn't seem ike most of the changes should affect us, mostly removing some imports we don't use and CJS/ESM export stuff similar to #726

@agilgur5 agilgur5 added the topic: Rollup 2 Related to Rollup 2 upgrade label Sep 21, 2020
@agilgur5
Copy link
Collaborator

agilgur5 commented Sep 21, 2020

Welp, tried upgrading and got a warning on install 😕 :

warning " > @rollup/plugin-commonjs@15.0.0" has incorrect peer dependency "rollup@^2.22.0".

This peerDep was actually changed during v12.0.0, but of course the Changelog makes no mention of it... rollup/plugins#149, the PR that adds it, does say it includes a breaking change with that change 😕 😕

So this is blocked on Rollup 2 upgrade #545

@agilgur5
Copy link
Collaborator

Superseded by #889

@agilgur5 agilgur5 closed this Sep 28, 2020
@agilgur5 agilgur5 added the solution: duplicate This issue or pull request already exists label Sep 28, 2020
@agilgur5 agilgur5 mentioned this pull request Sep 28, 2020
ludofischer added a commit to ludofischer/tsdx that referenced this pull request Sep 29, 2020
 - Update Rollup to 2.28.2. Fixes jaredpalmer#821, closes jaredpalmer#545
 - Update @rollup/plugin-commonjs. Upgrading this required Rollup 2 without any note in the changelog.  Closes jaredpalmer#727
 - Update @rollup/plugin-json to 4.1.0. v4.0.3 is the first to add Rollup 2 in the peerDep range. Older versions are forward-compatible but will produce a peerDep warning
 - Update @rollup/plugin-replace to 2.3.3. v2.3.2 is the first version to add Rollup 2 in the peerDep range.
 - Update rollup-plugin-terser to v7. v6 requires rollup 2 and Node 10+. v7 introduces Terser 5, requires Node >= 10 and supports some new JS syntax. fixes jaredpalmer#803, #fixes 797, closes jaredpalmer#731
 - Update rollup-plugin-postcss to 3.1. Closes jaredpalmer#693.
 - Remove sourcemap option from terser rollup plugin config, as of rollup-plugin-terser v6.0, it’s inferred automatically from Rollup’s output.source config.
@agilgur5 agilgur5 deleted the greenkeeper/@rollup/plugin-commonjs-12.0.0 branch September 30, 2020 20:13
aladdin-add pushed a commit to weiran-zsd/dts-cli that referenced this pull request Aug 30, 2021
 - Update Rollup to 2.28.2. Fixes jaredpalmer#821, closes jaredpalmer#545
 - Update @rollup/plugin-commonjs. Upgrading this required Rollup 2 without any note in the changelog.  Closes jaredpalmer#727
 - Update @rollup/plugin-json to 4.1.0. v4.0.3 is the first to add Rollup 2 in the peerDep range. Older versions are forward-compatible but will produce a peerDep warning
 - Update @rollup/plugin-replace to 2.3.3. v2.3.2 is the first version to add Rollup 2 in the peerDep range.
 - Update rollup-plugin-terser to v7. v6 requires rollup 2 and Node 10+. v7 introduces Terser 5, requires Node >= 10 and supports some new JS syntax. fixes jaredpalmer#803, #fixes 797, closes jaredpalmer#731
 - Update rollup-plugin-postcss to 3.1. Closes jaredpalmer#693.
 - Remove sourcemap option from terser rollup plugin config, as of rollup-plugin-terser v6.0, it’s inferred automatically from Rollup’s output.source config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
greenkeeper progress: blocked solution: duplicate This issue or pull request already exists topic: Rollup 2 Related to Rollup 2 upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant