Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @rollup/plugin-node-resolve to the latest version 🚀 #726

Closed

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented May 20, 2020


🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io


The dependency @rollup/plugin-node-resolve was updated from 7.1.3 to 8.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: shellscape
License: MIT

Find out more about this release.


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@agilgur5
Copy link
Collaborator

agilgur5 commented Aug 30, 2020

Changelog is not super helpful, says default exports were added but not why that's a breaking major instead of a minor. EDIT: Per the two changes labeled as breaking, rollup/plugins#301 and rollup/plugins#361, it's because it changes exports from CJS to ESM. It also adds a DEFAULTS variable which is actually useful since we copy that right now and have a comment to be explicit about it

v9 is also out which similarly has a not super helpful Changelog entry that says deps were updated but again not why that's breaking instead of patch or minor. Looking at the specific commit, seems to be because it makes it Node 10+ only.

This PR only updates to v8, but we probably want to supersede it with one for v9 that will be Node 10+ as a result

@agilgur5
Copy link
Collaborator

Superseded by #879

@agilgur5 agilgur5 deleted the greenkeeper/@rollup/plugin-node-resolve-8.0.0 branch September 21, 2020 05:08
@agilgur5 agilgur5 added the solution: duplicate This issue or pull request already exists label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
greenkeeper solution: duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant