Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade several more deps' majors #879

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

agilgur5
Copy link
Collaborator

Description

  • @types/node v13 -> v14

  • @types/fs-extra was recently updated to v9, so can bump it to match
    the recent upgrade of fs-extra itself to v9

  • rollup-plugin-sourcempas v0.5 -> v0.6

    • requires Node 10+, which we've already bumped to in the last dep
      upgrade, otherwise no breaking changes
  • @rollup/plugin-node-resolve v7 -> v9

    • requires Node 10+, which we've already bumped to in the last dep
      upgrade, other breaking changes don't affect our usage
    • use the new DEFAULTS variables to pull out the extensions instead
      of having a comment referencing them
      • rename this DEFAULTS to RESOLVE_DEFAULTS and Babel's
        DEFAULT_EXTENSIONS to DEFAULT_BABEL_EXTENSIONS so that there's
        less naming confusion around these
  • fix execa being pinned to v4.0.0 exactly

    • this was probably accidentally added as such because sometimes
      yarn add dep@x sets it exactly instead of to the caret version

Tags

This is basically a follow-up to #678 , including fixing the accidental exact execa pin created. Also adds the @types/fs-extra upgrade that didn't exist back then.

Closes a few related Greenkeeper PRs:

- @types/node v13 -> v14
  - Node 13.x was EoL at the beginning of June per
    https://github.com/nodejs/Release
- @types/fs-extra was recently updated to v9, so can bump it to match
  the recent upgrade of fs-extra itself to v9
- rollup-plugin-sourcempas v0.5 -> v0.6
  - requires Node 10+, which we've already bumped to in the last dep
    upgrade, otherwise no breaking changes

- @rollup/plugin-node-resolve v7 -> v9
  - requires Node 10+, which we've already bumped to in the last dep
    upgrade, other breaking changes don't affect our usage
  - use the new `DEFAULTS` variables to pull out the extensions instead
    of having a comment referencing them
    - rename this `DEFAULTS` to `RESOLVE_DEFAULTS` and Babel's
     `DEFAULT_EXTENSIONS` to `DEFAULT_BABEL_EXTENSIONS` so that there's
      less naming confusion around these

- fix execa being pinned to v4.0.0 exactly
  - this was probably accidentally added as such because sometimes
    `yarn add dep@x` sets it exactly instead of to the caret version
@vercel
Copy link

vercel bot commented Sep 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/m11oys6lt
✅ Preview: https://tsdx-git-fork-agilgur5-update-more-deps-v0140.formium.vercel.app

@agilgur5 agilgur5 added the scope: dependencies Pull requests that update a dependency file label Sep 21, 2020
Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some confusing changes, but they're all correct. LGTM 👍

src/createRollupConfig.ts Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
@agilgur5
Copy link
Collaborator Author

Deleted all the stale old Greenkeeper branches associated with all versions of the deps upgraded: @types/node, @types/fs-extra, rollup-plugin-sourcemaps, @rollup/plugin-node-resolve

paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
- @types/node v13 -> v14
  - Node 13.x was EoL at the beginning of June per
    https://github.com/nodejs/Release
- @types/fs-extra was recently updated to v9, so can bump it to match
  the recent upgrade of fs-extra itself to v9
- rollup-plugin-sourcempas v0.5 -> v0.6
  - requires Node 10+, which we've already bumped to in the last dep
    upgrade, otherwise no breaking changes

- @rollup/plugin-node-resolve v7 -> v9
  - requires Node 10+, which we've already bumped to in the last dep
    upgrade, other breaking changes don't affect our usage
  - use the new `DEFAULTS` variables to pull out the extensions instead
    of having a comment referencing them
    - rename this `DEFAULTS` to `RESOLVE_DEFAULTS` and Babel's
     `DEFAULT_EXTENSIONS` to `DEFAULT_BABEL_EXTENSIONS` so that there's
      less naming confusion around these

- fix execa being pinned to v4.0.0 exactly
  - this was probably accidentally added as such because sometimes
    `yarn add dep@x` sets it exactly instead of to the caret version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: dependencies Pull requests that update a dependency file topic: Node 10+ requires Node 10+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant