feat(node-resolve): Add default export #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
force-pushed
the
feat/node-resolve/default-export
branch
from
81be79b to
ce8fed8
Compare
|
Do you mean "Add named export"? |
|
We've switched to named exports already here, this adds back an export named "default". |
shellscape
reviewed
May 2, 2020
packages/alias/README.md
Outdated
| @@ -140,9 +140,9 @@ Example: | |||
| ```javascript | |||
| // rollup.config.js | |||
| import alias from '@rollup/plugin-alias'; | |||
| import resolve from '@rollup/plugin-node-resolve'; | |||
| import { nodeResolve } from '@rollup/plugin-node-resolve'; | |||
There was a problem hiding this comment.
let's keep this scoped to node-resolve for now, and update the plugins individually. we'll want to do a patch release for each so the docs on npm match the repo. for that we need individual commits for each plugin to keep the changelogs and publishing automation correct.
There was a problem hiding this comment.
I'll revert these doc changes since the path forward should allow us to keep the same import format.
NotWoods
force-pushed
the
feat/node-resolve/default-export
branch
from
ce8fed8 to
e99441a
Compare
larrybotha
added a commit
to larrybotha/plugins
that referenced
this pull request
May 20, 2020
# By Tiger Oakes (2) and others # Via GitHub * master: feat(wasm): Switch to TypeScript & named exports (rollup#363) feat(node-resolve): Add default export (rollup#361) fix (sucrase): resolve directory imports (rollup#390) docs(typescript): update readme examples (rollup#391) # Conflicts: # packages/sucrase/test/snapshots/test.js.md # packages/sucrase/test/snapshots/test.js.snap # packages/sucrase/test/test.js # pnpm-lock.yaml
LarsDenBakker
pushed a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
BREAKING CHANGES: - Corrects TypeScript interface name - Adds default export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
Building on #301, this updates the documentation but also re-adds a default export. When the plugin is used with ES modules, the previous change is no longer a breaking change. However, CommonJS modules still must switch to named exports.
For consistency we should always used named exports in the documentation, but this helps users migrate to the new format.