Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade next from 9.4.4 to 9.5.0 #807

Closed

Conversation

snyk-bot
Copy link

Snyk has created this PR to upgrade next from 9.4.4 to 9.5.0.

merge advice

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 47 versions ahead of your current version.
  • The recommended version was released 23 days ago, on 2020-07-27.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Snyk has created this PR to upgrade next from 9.4.4 to 9.5.0.

See this package in npm:


See this project in Snyk:
https://app.snyk.io/org/jaredpalmer/project/3b0a6589-6481-495e-91cd-aab6a439fd08?utm_source=github&utm_medium=upgrade-pr
@vercel
Copy link

vercel bot commented Aug 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/4qudvcpgo
✅ Preview: https://tsdx-git-snyk-upgrade-b86d1f4c0c38ef74a52a9e19fed8886c.formium.vercel.app

@agilgur5
Copy link
Collaborator

agilgur5 commented Aug 19, 2020

@jaredpalmer can you please give me admin access to Snyk and any other bots (including Vercel, ImgBot, and dependabot)? This is Snyk's second duplicate of #806 and #804 and all three of them unnecessarily bump a minor version when the package.json SemVer policy allows minors anyway. And all of them are to the website, so it doesn't matter if those deps are up to date (or vulnerable) anyway. Snyk also isn't labeling its PRs which makes it difficult to sort through.

As I've mentioned to you before, Greenkeeper was similar and was just making dozens of unnecessary PRs that clog notifications, clog search, clog PR view, and give a bad image but I had no way of changing it (or upgrading to Snyk) since I had no access. Now Snyk is even worse and I sill have no access after asking for months and you're not responding to its PRs either (so I have no control over something I didn't add but have to maintain it somehow). If we keep letting Snyk do its thing for unnecessary patches, minors, etc the repo is going to be 90% dep PRs (it's probably at least 5% already, if not 10%) and 90% dep commits if those were merged. It's adding a ton of unnecessary noise with very little signal right now, with bugs at that

@agilgur5 agilgur5 added the solution: duplicate This issue or pull request already exists label Aug 19, 2020
@agilgur5
Copy link
Collaborator

agilgur5 commented Aug 21, 2020

And now it opened yet another PR for a patch bump in #809... Greenkeeper would at least re-use PRs, Snyk is going crazy cluttering all the PRs, I can't see how this is would be considered useful...

@jaredpalmer please give me admin access to Snyk and all other bots, this is really frustrating to deal with and I have no control over it

@agilgur5
Copy link
Collaborator

@jaredpalmer It just made another duplicate with #812... it's literally making two unnecessary PRs a day and I have no control over it

@agilgur5
Copy link
Collaborator

agilgur5 commented Aug 23, 2020

@jaredpalmer And it just made one more duplicate with #813 ... this is just ridiculous now...

@agilgur5 agilgur5 added the solution: unnecessary This PR makes unnecessary or redundant changes label Aug 23, 2020
@agilgur5
Copy link
Collaborator

@jaredpalmer one more duplicate with #825 ... It also just made 5 more unnecessary PRs to upgrade minor versions of dependencies that are only pinned to majors anyway... See the "unnecessary" label I've added to track these and PRs to website/

@agilgur5
Copy link
Collaborator

agilgur5 commented Aug 31, 2020

Snyk has been removed (response was on the wrong issue again... asked about that here). Closing, per above, as since this just updated a minor, which wasn't pinned anyway, and was on the /website dir, which isn't a library.

@agilgur5 agilgur5 closed this Aug 31, 2020
Repository owner locked and limited conversation to collaborators Aug 31, 2020
@agilgur5 agilgur5 deleted the snyk-upgrade-b86d1f4c0c38ef74a52a9e19fed8886c branch August 31, 2020 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
solution: duplicate This issue or pull request already exists solution: unnecessary This PR makes unnecessary or redundant changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants