Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greenkeeper: remove website from greenkeeper config #815

Merged
merged 1 commit into from
Aug 23, 2020

Conversation

agilgur5
Copy link
Collaborator

Description

  • website doesn't need vulnerability updates because it has no forms or
    real attack surface and it is not a published library that others
    depend on

    • greenkeeper wasn't just for vulnerability updates though; automatic
      dep updates aren't necessary either as no one depends on it and it's
      not frequently used (until recently was last updated ~6 months ago)
  • greenkeeper is no longer a thing, but not sure if Snyk is perhaps
    using the same config, so try changing it to reduce all these
    unnecessary, duplicative, and buggy Snyk PRs

    • based on the website / docs, it doesn't sound like this will change
      anything and this file should probably be deleted, but since I don't
      have access to Snyk to be able to change settings, this is all I
      can try

Tags

c.f. #807 .. and #806 and #804 and #809 and #812 and #813 and probably more...

- website doesn't need vulnerability updates because it has no forms or
  real attack surface and it is not a published library that others
  depend on
  - greenkeeper wasn't just for vulnerability updates though; automatic
    dep updates aren't necessary either as no one depends on it and it's
    not frequently used (until recently was last updated ~6 months ago)

- greenkeeper is no longer a thing, but not sure if Snyk is perhaps
  using the same config, so try changing it to reduce all these
  unnecessary, duplicative, and buggy Snyk PRs
  - based on the website / docs, it doesn't sound like this will change
    anything and this file should probably be deleted, but since I don't
    have access to Snyk to be able to change settings, this is all I
    can try
@vercel
Copy link

vercel bot commented Aug 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/ba1u7o6on
✅ Preview: https://tsdx-git-fork-agilgur5-no-greenkeeper-on-website.formium.vercel.app

Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-liner LGTM

@agilgur5 agilgur5 merged commit fc22471 into jaredpalmer:master Aug 23, 2020
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
- website doesn't need vulnerability updates because it has no forms or
  real attack surface and it is not a published library that others
  depend on
  - greenkeeper wasn't just for vulnerability updates though; automatic
    dep updates aren't necessary either as no one depends on it and it's
    not frequently used (until recently was last updated ~6 months ago)

- greenkeeper is no longer a thing, but not sure if Snyk is perhaps
  using the same config, so try changing it to reduce all these
  unnecessary, duplicative, and buggy Snyk PRs
  - based on the website / docs, it doesn't sound like this will change
    anything and this file should probably be deleted, but since I don't
    have access to Snyk to be able to change settings, this is all I
    can try
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant