Support min/max cardinality

[mwawrusch]

I would like to have the ability to specify how many items a field can contain. For example, a contact could have more than one phone number. From a UI perspective the apple contact screen works very well.

What do you guys think about that, could you see it as part of the library, or as an extra module?

[kentcdodds]

Perhaps it could fit into the library... What kind of api do you think would make it generic and useful to others?

[ghelton]

I recently setup a custom text field and set the max length using the native maxlength attribute. For some reason ng-maxlength wasn't working for me at all.
maxlength="{{options.maxlength}}"
I think this would be a good addition to the templates.

[kentcdodds]

Correct me if I'm wrong, but I don't think @mwawrusch was talking about the length of text in an input but rather having multiples of the same input. Like a contact having multiple phone numbers. I'm thinking this would be difficult to generalize enough to support more than a single use case...

[jhr007]

Independent of this repo ( not that a PR wouldn't be welcome) it might be doable by creating a custom directive in a custom HTML template that is added to formly.

The 'multi-phone' directive would handle the add/remove of the phone field (ng repeat over an array that builds the number fields)

You might be able to treat the formData.multiPhoneList variable received by the directive as an array. In the field eg. ng-model="multiPhoneList[$index].phoneNumber"

And
ng-model="multiPhoneList[$index].phoneType" (work/home/mobile)

Where $index is from the ng-repeat.

Otherwise you'd have to $watch the fields in the directive and update a hidden field that is bound to formData.

Hope this makes sense

/2 cents

Sent from my iPhone

On Aug 22, 2014, at 1:25 PM, Martin Wawrusch notifications@github.com wrote:

I would like to have the ability to specify how many items a field can contain. For example, a contact could have more than one phone number. From a UI perspective the apple contact screen works very well.

What do you guys think about that, could you see it as part of the library, or as an extra module?

—
Reply to this email directly or view it on GitHub.

[kentcdodds]

Yeah, I definitely believe it belongs in a standalone directive. Whether or not it's included in the library or not is another matter. I'm still on the fence on that one. @Astrism?

[mwawrusch]

Sorry, was offline for a bit.
I think the easiest api would be to add a min and a max field to each fields definition, defaulting to 0 .. 1. Everything else could be derived from that. For example, 4 .. 4 would expect an array as underlying value field, and renders 4 fields, one for each value. something like 1..5 on the other hand would only present one input field, and once something is entered there, add another input field below.

As a final remark, the same should work with sub forms as well (think address input on the iphone).

[kentcdodds]

Personally I'd like to see this implemented outside of the library before we think about bringing it in...

[mwawrusch]

Let me see what I can do.

[jhr007]

I agree it should be separate as such a specific use case, OR included as a magical example after future maintenance concerns are addressed.

To be included in the library I think the bar should be set high. Eg. It should be able to wrap almost any field. But this would mean as formly loops over the field array it detects a multi-field and treats it accordingly.

Sent from my iPhone

On Aug 22, 2014, at 2:31 PM, "Kent C. Dodds" notifications@github.com wrote:

Yeah, I definitely believe it belongs in a standalone directive. Whether or not it's included in the library or not is another matter. I'm still on the fence on that one. @Astrism?

—
Reply to this email directly or view it on GitHub.

[ghelton]

Agreed, I never intended for this library to go too far above native Angular support for forms. For that kind of support I like the idea individual library plugins, i.e. UI-Bootstrap or Angular-Strap for their more enhanced UI components. It is my opinion that the base Formly should be UI agnostic if possible.

[kentcdodds]

I like that. So @Astrism, do you think that there should be a separate repo for angular-strap and ui-bootstrap templates altogether? I like the idea of having plugins. Thinking a separate repo for these seems appealing... Then you could install formly and the plugin you care about separately...

[ghelton]

Yep, moving this discussion over there :)

[kentcdodds]

@mwawrusch, any progress on this? Is there any reason to keep this issue open?

[mwawrusch]

Got cought up doing other stuff. Will implement this next week and see how
it goes.

On Saturday, August 30, 2014, Kent C. Dodds notifications@github.com
wrote:

@mwawrusch https://github.com/mwawrusch, any progress on this? Is there
any reason to keep this issue open?

—
Reply to this email directly or view it on GitHub
https://github.com/nimbly/angular-formly/issues/76#issuecomment-53978456
.

Martin Wawrusch
p: +1 310 404 1698

modeista.com - Connect With Style
fanignite.com - ALPHA - Create Your Mobile App In 30 Seconds
wawrusch.com - Personal Blog
codedoctor.co - Professional Blog

Follow me on twitter at @MartinWawrusch http://twitter.com/MartinWawrusch