Disaster! (Really: Missing Submit Button)

[gizmoboy]

We had the bad misfortune of our developer who was working with formly leaving the company on Friday, just after he pushed his (customized) version of formly to the staging environment.

Now, the forms are not showing any submit button which had been working prior to the latest update.

To be clear, I know this is our fault, since the demos all work fine. Not blaming the update.

I know there were some significant changes in 0.0.16, and I'm wondering if any of them might have affected whether the Submit button shows, and the developer missed applying the changes.

(I have stepped into the code and confirmed that $scope.formOptions.hideSubmit is false, but I can't tell where that gets read by formly to check it closer to the metal.)

[kentcdodds]

With version 0.0.16, the submit button works just the same as it always has. See here for information on how to configure options for the submit button.

In master, things have been changed around a bit where the formly-form doesn't have a submit button. This is leading up to our 0.1.0 update which will hopefully happen as soon as @Astrism returns from his travels.

If you're running on master, then you'll benefit from looking at how the demo adds a submit button. If you're on 0.0.16 then I'm not certain what your issue is. If your developer made a custom build of formly I would recommend that you don't do that... Just let us know what was lacking from formly and we'll see what we can do to support your use cases...

[gizmoboy]

I now have a new developer undoing all the customizations and extending formly via directives and custom templates (which is what I thought the former developer was doing).

[gizmoboy]

Where does hideSubmit get checked in the 0.16 code? I want to make sure that it's not being changed somewhere after I've inspected it.

[kentcdodds]

Good plan. If we don't provide the proper apis, please let me know...

[kentcdodds]

In 0.0.16, the ability to configure formly to use ng-if instead of ng-hide was implemented and the formly-form.html template was removed. This was an enhancement and not a breaking change.

The part of the template that checks hideSubmit is here. In the compile function below, the template is altered based on whether the form is supposed to use ng-if. Let me know if there's a bug in there that needs to be fixed.

You may also consider updating to master as this is the direction we're heading soon anyway. See the changelog for the breaking changes your new developer will need to account for.

[gizmoboy]

He did cut us over to using ng-if. I will dig into this and see if he missed something.

[gizmoboy]

He's missing that whole section in the formlyForms directive.

How stable is master to use?

[kentcdodds]

Hmmm... There may be some changes, but I believe the api should remain pretty stable. If you like, I'll make sure to let you know when there are any breaking changes. Honestly, I would recommend simply using the hash in your bower dependency so you don't get auto-upgraded.

But I believe the api should be consistent. However, one major change upcoming will be when we break formly away from the templates and break them out into separate repositories. This should be coming pretty soon and the dist folder for this repository will contain only formly.js and formly.min.js. You'll have to add a dependency on the template directory of your choice to get the built-in templates you enjoy now.

I've created an issue (#94) where I'll post when things like this happen if you'd like to stay up to date.

[kentcdodds]

I'm going to close this for now as the root issue was resolved.