Skip to content
This repository was archived by the owner on Apr 30, 2018. It is now read-only.

Conversation

gizmoboy
Copy link
Contributor

@gizmoboy gizmoboy commented Sep 1, 2014

An additional watcher on the Edit JSON button now pulls the current value of formData back into formDataStr for editing.

… value of formData back into formDataStr for editing.
@kentcdodds
Copy link
Member

This is great! Thanks. I'll give it a look over soon and merge it in.

  • Kent C. Dodds
    Sent from my mobile device, please forgive any errors or brevity. (I may
    have used speech to text...)
    On Sep 1, 2014 11:19 AM, "gizmoboy" notifications@github.com wrote:

An additional watcher on the Edit JSON button now pulls the current value

of formData back into formDataStr for editing.

You can merge this Pull Request by running

git pull https://github.com/gizmoboy/angular-formly master

Or view, comment on, or merge it at:

https://github.com/nimbly/angular-formly/pull/90
Commit Summary

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
https://github.com/nimbly/angular-formly/pull/90.

@kentcdodds
Copy link
Member

This code doesn't follow our spacing style (we use tabs, that was not my decision...). Could you please make the necessary updates to use tabs instead of spaces?

@kentcdodds
Copy link
Member

Other than that this looks great. Thanks for doing this!

@gizmoboy
Copy link
Contributor Author

gizmoboy commented Sep 1, 2014

Will do.

Best,

-- jas

http://www.linkedin.com/in/jeffreysullivan

*** Sent from my mobile device. Please excuse brevity and errors. ***

On Sep 1, 2014, at 3:03 PM, "Kent C. Dodds" notifications@github.com wrote:

This code doesn't follow our spacing style (we use tabs, that was not my decision...). Could you please make the necessary updates to use tabs instead of spaces?


Reply to this email directly or view it on GitHub.

… value of formData back into formDataStr for editing. Reformatted spacing for TABs.
@@ -50,7 +50,7 @@ app.controller('home', function($scope, $parse, $window, usingCustomTypeTemplate
$scope.formFieldsError = true;
}
});
$scope.$watch('formDataStr', function onDataUpdated(newValue) {
$scope.$watch('formDataStr', function onDataUpdated(newValue) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is still using spaces. This line should not change.

# By Kent C. Dodds (2) and Krzysztof Hasiński (1)
# Via Kent C. Dodds
* 'master' of https://github.com/nimbly/angular-formly:
  grunt build
  Fixes formly-js#95.
  Fixed a typo

Conflicts:
	dist/formly.bootstrap.min.map
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants