-
Notifications
You must be signed in to change notification settings - Fork 399
Fixes #89. #90
Fixes #89. #90
Conversation
… value of formData back into formDataStr for editing.
This is great! Thanks. I'll give it a look over soon and merge it in.
|
This code doesn't follow our spacing style (we use tabs, that was not my decision...). Could you please make the necessary updates to use tabs instead of spaces? |
Other than that this looks great. Thanks for doing this! |
Will do. Best, -- jashttp://www.linkedin.com/in/jeffreysullivan *** Sent from my mobile device. Please excuse brevity and errors. ***
|
… value of formData back into formDataStr for editing. Reformatted spacing for TABs.
@@ -50,7 +50,7 @@ app.controller('home', function($scope, $parse, $window, usingCustomTypeTemplate | |||
$scope.formFieldsError = true; | |||
} | |||
}); | |||
$scope.$watch('formDataStr', function onDataUpdated(newValue) { | |||
$scope.$watch('formDataStr', function onDataUpdated(newValue) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is still using spaces. This line should not change.
# By Kent C. Dodds (2) and Krzysztof Hasiński (1) # Via Kent C. Dodds * 'master' of https://github.com/nimbly/angular-formly: grunt build Fixes formly-js#95. Fixed a typo Conflicts: dist/formly.bootstrap.min.map
An additional watcher on the Edit JSON button now pulls the current value of formData back into formDataStr for editing.