This repository was archived by the owner on Apr 30, 2018. It is now read-only.
Partially revert 0225a1 #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 0225a1 prevented accessing a possibly null/undefined dictionary inside the scope, but the way it was handling it was preventing formly-dynamic-name-update listener from been registered. The proposed solution keeps checking for if $scope.formOnParentScope is defined, but inside the event handler, making it aware of scope changes
Closed
|
Looks awesome. I'll merge, then pull, build, and push, and redeploy. Thanks! |
|
Awesome, if anyone needs this right now they can point to e3d165a in their bower and get this feature. Hopefully we'll be able to release a new version soon. Thanks for the help @manuelnaranjo! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0225a1 prevented accessing a possibly null/undefined dictionary inside
the scope, but the way it was handling it was preventing formly-dynamic-name-update
listener from been registered.
The proposed solution keeps checking for if $scope.formOnParentScope is defined,
but inside the event handler, making it aware of scope changes