Fix I18n lookup for enum values in nested select fields #1342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes the same as #1227, albeit with a more focused approach.
When constructing the key for looking up the localized enum value, we now use
ActiveModel::Name.i18n_key
instead ofobject_name
, which returned something likeuser[posts_attributes][0]
in case of nested forms.I've added a test that reproduces the exact scenario that triggered the fixed bug (#1151).
Bonus: I've added a commit to update Formtastic version in Gemfile.lock (it was still 4.0.0.rc1).
Fixes #1151
Supersedes #1227