Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for events that update Accounts #205

Closed
2 tasks
eureka-cpu opened this issue Jun 7, 2024 · 0 comments · Fixed by #210
Closed
2 tasks

Add tests for events that update Accounts #205

eureka-cpu opened this issue Jun 7, 2024 · 0 comments · Fixed by #210
Assignees
@hathbanger @eureka-cpu
Labels
bug Something isn't working

Comments

@eureka-cpu
Copy link
Contributor

eureka-cpu commented Jun 7, 2024 •
edited
Loading

Often we are running into issues with accounts not being updated as expect, ie bridging in overwrites the balance, and having tests that apply each event to an account and make assertions of what that account snapshot should look like would help find the issues faster.

  • Internal testing: If we can make some kind of helper macro that will set up the account and then use a dev-dependency like expect-test, it should give us a lot more visibility as to what failed, where and why. @eureka-cpu
  • E2E testing: We need a basic lasr program that will make each call that will update an account and make assertions about what that account snapshot should look like each step of the way. This program should have a deployment process eventually so that we can always have a program running that checks the effects of network on an account. @hathbanger
@eureka-cpu eureka-cpu added the bug Something isn't working label Jun 7, 2024
@eureka-cpu eureka-cpu mentioned this issue Jun 12, 2024
Merged
eureka-cpu added a commit that referenced this issue Jun 17, 2024
@eureka-cpu
Add testing framework for events that update Account (#210)
a606e80 
Closes #205 

Adds the tests necessary to prove events that update `Account` function
as intended. Also adds the ability to test with in-memory key-value
storage (`HashMap`) which relieves the overhead of needing a
`tikv_client` running. The `MinimalNode` testing type can eventually be
moved to its own module and expanded upon if needed, which makes testing
node processes outside of RPC calls, IPFS and other compute related
stuff (outside of the scope of these tests) relatively easy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hathbanger hathbanger

@eureka-cpu eureka-cpu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add testing framework for events that update Account formthefog/lasr
2 participants
@hathbanger @eureka-cpu