Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout IPFS Calls #223

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Timeout IPFS Calls #223

merged 4 commits into from
Jun 20, 2024

Conversation

mitch-vrrb
Copy link
Contributor

@mitch-vrrb mitch-vrrb commented Jun 19, 2024 •
edited by eureka-cpu
Loading

Closes #215

@mitch-vrrb mitch-vrrb requested a review from eureka-cpu June 19, 2024 17:25
@mitch-vrrb mitch-vrrb self-assigned this Jun 19, 2024
eureka-cpu
eureka-cpu previously approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@eureka-cpu eureka-cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are you planning to do the EO calls in a separate PR?

@eureka-cpu eureka-cpu added the enhancement Improvement to an existing feature label Jun 19, 2024
@mitch-vrrb mitch-vrrb merged commit 269a167 into main Jun 20, 2024
2 of 3 checks passed
@mitch-vrrb mitch-vrrb deleted the mitch/timeout-ipfs-calls branch June 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eureka-cpu eureka-cpu eureka-cpu approved these changes

Assignees

@mitch-vrrb mitch-vrrb

Labels
enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add timeout limits for external async calls to IPFS & EO
2 participants
@mitch-vrrb @eureka-cpu