Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract & Update logic in Batcher::add_transaction_to_account() #226

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

andrewvious
Copy link
Contributor

@andrewvious andrewvious commented Jun 20, 2024

Closes #222
Abstracts bridge logic from apply_send_transaction(), and add's two new fns to handle the logic previously stored in add_transaction_to_account().

  • First handles token updates for BridgeIn event
  • Second handles token updates for accounts involved in Send event

Removes redundant logic for ETH_ADDR & VERSE_ADDR since the two are in persistence, and the logic is never reached.
If we want specific logging for these, I can rewrite the logic to match for them rather than having them in if else statements. Otherwise I don't see the need for it.

@andrewvious andrewvious added the code quality Improves either readability of code, or organizational structure label Jun 20, 2024
@andrewvious andrewvious self-assigned this Jun 20, 2024
@andrewvious andrewvious requested a review from eureka-cpu June 20, 2024 22:18
@andrewvious andrewvious requested a review from eureka-cpu June 21, 2024 01:03
@eureka-cpu
Copy link
Contributor

@andrewvious was this waiting on something?

@andrewvious
Copy link
Contributor Author

@andrewvious was this waiting on something?

I'd like to test it in either DO box or lasr vm before merging, awaiting approval as well @eureka-cpu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improves either readability of code, or organizational structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract logic in Batcher::add_transaction_to_account()
2 participants