Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clippy CI check to workflow #99

Merged
merged 19 commits into from
Jun 17, 2024
Merged

Add clippy CI check to workflow #99

merged 19 commits into from
Jun 17, 2024

Conversation

andrewvious
Copy link
Contributor

Closes #75

The clippy check isn't currently passing, working on getting the warnings taken care of in a separate PR.

@andrewvious andrewvious added the CI Anything to do with GitHub actions label Apr 3, 2024
@andrewvious andrewvious self-assigned this Apr 3, 2024
@andrewvious andrewvious marked this pull request as ready for review June 14, 2024 18:01
@andrewvious
Copy link
Contributor Author

andrewvious commented Jun 14, 2024

There are only a few clippy warnings left revolving around a manual implementation of an assigned operation, function cannot return without recursing, and direct implementation of ToString.
These warning's can be handled in a separate PR need be @eureka-cpu @mitch-vrrb

@mitch-vrrb
Copy link
Contributor

mitch-vrrb commented Jun 14, 2024

Those clippy errors aren't warnings, this test overflows the stack:

#[cfg(test)]
mod test {
    #[test]
    fn test_u256_into() {
        let eth_u256: ethereum_types::U256 = ethereum_types::U256::one();

        let token_u256: &mut super::U256 = eth_u256.into();
    }
}

Copy link
Contributor

@eureka-cpu eureka-cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you see if removing the recursive From implementations causes any failures? Left one other review comment, otherwise looks good.

.github/workflows/rust.yml Outdated Show resolved Hide resolved
@andrewvious andrewvious requested a review from eureka-cpu June 17, 2024 05:32
@andrewvious andrewvious requested a review from eureka-cpu June 17, 2024 16:59
Copy link
Contributor

@eureka-cpu eureka-cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, the check doesn't necessarily need to pass for this to go in.

@andrewvious andrewvious merged commit 505dfb5 into main Jun 17, 2024
2 of 3 checks passed
@andrewvious andrewvious deleted the andrewvious/75 branch June 17, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Anything to do with GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clippy CI check
3 participants