-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clippy CI check to workflow #99
Conversation
There are only a few clippy warnings left revolving around a |
Those clippy errors aren't warnings, this test overflows the stack:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you see if removing the recursive From
implementations causes any failures? Left one other review comment, otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, the check doesn't necessarily need to pass for this to go in.
Closes #75
The clippy check isn't currently passing, working on getting the warnings taken care of in a separate PR.