Make left clicking on test open test by default #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Mind fixing the tslint errors? You can do a npm run tslint in the root folder to see the errors locally (there's also a tslint extensions for vscode). |
davidpendraykalibrate
force-pushed
the
NewLeftClickGoToTest
branch
from
497ae84
to
29aa7bc
Compare
User can configure this behaviour via leftClickAction to either: - runTest - goToTest - doNothing When user clicks a test, this is initially handled by leftClickTest command which checks configuration and then passes request to appropriate handler. This ensures that when user changes configuration, the next click is handled correctly.
davidpendraykalibrate
force-pushed
the
NewLeftClickGoToTest
branch
from
29aa7bc
to
b33764a
Compare
|
Done and got rid of merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can configure this behaviour via leftClickAction to either:
When user clicks a test, this is initially handled by leftClickTest
command which checks configuration and then passes request to
appropriate handler. This ensures that when user changes configuration,
the next click is handled correctly.
Replaces #108