Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dots in inline data #146

Merged

Conversation

stefanforsberg
Copy link
Collaborator

No description provided.

@stefanforsberg stefanforsberg merged commit d38d89e into formulahendry:master Sep 19, 2018
@jadenguy
Copy link

jadenguy commented Oct 24, 2018

Is this handled as in 'fixed', or handled as in caught? Because it doesn't seem 'fixed'. I love the extension otherwise, but thought this was a bit odd.

https://github.com/jadenguy/nUnitTest

There's odd behavior between refreshing and running tests. Specifically if all of the tests have dots in them.

I'm not really sure how to write one of these, and I think I should probably open my own issue? I'm just worried I misunderstood this fix.

Refreshing

Good:

  • The name is right

Interesting:

  • The Run button does run all the tests, so it does eventually run the test in question

Bad:

  • Yields a flat list
  • You can't click on a test to go to the method in the editor
  • You can't run a single test

Running a single test

Good:

  • The test runs ...

Interesting:

  • ... as a subset of All tests, see above
  • There is a tree structure of tests ...

Bad:

  • ... but the tests are from the last run-all you've done, even from another project image
  • You can't click on a test to go to the method in the editor in either the flat or tree format

Running all tests

Good:

  • The test runs, and you can see the results for the most part!

Interesting:

  • There is a tree structure that matches the namespace and case description ...

Bad:

  • ... but the tests are nested under a malformed version of themselves
  • You can't click on a test to go to the method in the editor image

@stefanforsberg
Copy link
Collaborator Author

Hello @jadenguy and thanks for your through work!

The thing you are experiencing is likely due to a bug in vstest (#145 (comment)) and as such it's not easibly fixable in our extensions.

@stefanforsberg stefanforsberg deleted the f-inline-data-with-dots branch March 1, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants