Fix unfound tests when using Go to Test feature with F# #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello and thanks for the PR! At the moment we're trying to rewrite some things related to what you're doing since the vscode api has had a few changes. It might be a while before that is completed so I just wanted you to give a heads up that we've seen your PR and it might take a while before it's merged =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found when trying to go to tests in my F# project, I got a symbol not found error. I thought I would have a go at trying to fix it myself and so created a pull request.
I found the problem was that Ionide returns symbols for F# test functions as SymbolType.Variable (not sure why a variable and not a function), whereas currently symbols are filtered to be SymbolType.Method. Therefore, I added a check on the file extension and if it's a .fs I filter to be SymbolType.Variable. I also added a couple of tests.