Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test discovery experience #268

Merged
merged 6 commits into from
Jun 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"viewsWelcome": [
{
"view": "dotnetTestExplorer",
"contents": "No tests found. \n\nPlease open or set the test project and ensure your project compiles."
"contents": "No tests found. \n\nPlease open the test project and ensure your project compiles.\nIf the directory to execute dotnet test in is not the workspace root, consider setting dotnet-test-explorer.testProjectPath appropriately.\n[Open settings](command:workbench.action.openWorkspaceSettingsFile)"
}
],
"views": {
Expand Down Expand Up @@ -186,7 +186,12 @@
"dotnet-test-explorer.testProjectPath": {
"type": "string",
"default": "",
"description": "Glob pattern that points to path of .NET Core test project(s)."
"description": "Glob pattern that points to path of .NET Core test project(s).",
"examples": [
"**/*Test.@(csproj|vbproj|fsproj)",
"**/*Tests.@(csproj|vbproj|fsproj)",
"**/*.sln"
]
},
"dotnet-test-explorer.treeMode": {
"type": "string",
Expand Down
2 changes: 1 addition & 1 deletion src/executor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Logger } from "./logger";

export class Executor {

public static runInTerminal(command: string, cwd?: string, addNewLine: boolean = true, terminal: string = "Test Explorer"): void {
public static runInTerminal(command: string, cwd?: string, addNewLine: boolean = true, terminal: string = ".NET Test Explorer"): void {
if (this.terminals[terminal] === undefined) {
this.terminals[terminal] = vscode.window.createTerminal(terminal);
}
Expand Down
1 change: 1 addition & 0 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export function activate(context: vscode.ExtensionContext) {
}));

context.subscriptions.push(vscode.commands.registerCommand("dotnet-test-explorer.refreshTestExplorer", () => {
testDirectories.parseTestDirectories();
dotnetTestExplorer.refreshTestExplorer();
}));

Expand Down
2 changes: 1 addition & 1 deletion src/logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class Logger {
}
}

private static defaultOutput = "Test Explorer";
private static defaultOutput = ".NET Test Explorer";

private static outputTerminals: { [id: string]: vscode.OutputChannel } = {};

Expand Down