Faraday #219
Open
Faraday #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed up your PR, separated the We also need a Tor proxy capability in Faraday as described in lightninglabs/faraday#37 (comment) so we can keep netns-level Tor enforcement. |
sputn1ck
force-pushed
the
faraday
branch
2 times, most recently
from
0c82e25 to
6688a71
Compare
|
Please squash the commit history so that it's ready for review and add a test. |
|
Will update this with tests similiar to #313 |
|
Faraday is now available in nixpkgs: NixOS/nixpkgs#127333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Faraday. Faraday is a Lightning Channel Management & Optimization Tool by Lightning Labs. It is used in Lightning Terminal which could be pretty useful in the future.
I did this PR based on #209 as I have never created modules and pkgs myself. I have not tested the netns stuff and am not sure about the tests.