Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoind: add uptime to the public API whitelist #314

Merged
merged 1 commit into from
Feb 3, 2021
Merged

bitcoind: add uptime to the public API whitelist #314

merged 1 commit into from
Feb 3, 2021

Conversation

mmilata
Copy link
Contributor

@mmilata mmilata commented Feb 2, 2021

It is needed by lnd to check bitcoind health status since version 0.12.0: lightningnetwork/lnd#4755

If the api method is blocked lnd shuts down soon after starting.

# journalctl -b
...
Feb 02 22:13:30 nix-bitcoin bitcoind[8416]: 2021-02-02T21:13:30Z RPC User public not allowed to call method uptime
...
Feb 02 22:13:30 nix-bitcoin lnd[9845]: 2021-02-02 22:13:30.708 [CRT] SRVR: Health check: chain backend failed after 3 calls
Feb 02 22:13:30 nix-bitcoin lnd[9845]: 2021-02-02 22:13:30.708 [INF] SRVR: Sending request for shutdown
Feb 02 22:13:30 nix-bitcoin lnd[9845]: 2021-02-02 22:13:30.708 [INF] LTND: Received shutdown request.
Feb 02 22:13:30 nix-bitcoin lnd[9845]: 2021-02-02 22:13:30.708 [INF] LTND: Shutting down...

@mmilata
bitcoind: add uptime to the public api whitelist
86d7db9 
It is needed by lnd to check bitcoind health status since lnd-0.12.0.
@mmilata mmilata changed the title bitcoind: add uptime to the public api whitelist bitcoind: add uptime to the public API whitelist Feb 2, 2021
erikarvstedt
erikarvstedt approved these changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 86d7db9

@jonasnick jonasnick merged commit c0abae9 into fort-nix:master Feb 3, 2021
@mmilata mmilata deleted the bitcoind-public-uptime branch February 3, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikarvstedt erikarvstedt erikarvstedt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmilata @erikarvstedt @jonasnick