Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joinmarket: remove custom secp256k1 package #666

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

jonasnick
Copy link
Member

python-bitcointx 1.1.4 is compatible with libsecp256k1 0.4.0 in nixpkgs. Joinmarket uses libsecp256k1 only through python-bitcointx.

python-bitcointx 1.1.4 is compatible with libsecp256k1 0.4.0 in nixpkgs.
Joinmarket uses libsecp256k1 only through python-bitcointx.
Copy link
Collaborator

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e56ca3d

@erikarvstedt
Copy link
Collaborator

Had some sporadic test failures, not directly related to the changes introduced here. I'll address these in a separate PR.

@jonasnick jonasnick merged commit 243c221 into fort-nix:master Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants