-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update nixpkgs #744
update nixpkgs #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 967e170. The updates and LND config change seem reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did review this PR right after it was created. I noticed that test trustedcoin
is consistently failing due to a timeout at this step:
machine: waiting for success: journalctl -b --output=cat -u clightning --grep='plugin-trustedcoin[^^]\[0m\s+bitcoind RPC working'
Will look into this soon.
Oh, thanks @erikarvstedt. Good catch. |
So far using bitcoind v28.0 and LND via this PR branch has given me no issues. |
Blocked by nbd-wtf/trustedcoin#33 |
Fixed branch with trustedcoin update. |
@erikarvstedt Thanks! The trustedcoin test still fails for me due a time out at
|
Supports bitcoind 28.0.
bitcoin: 27.1 -> 28.0 bitcoind: 27.1 -> 28.0 clboss: 0.13.3 -> 0.14.0
Thanks, fixed my branch. |
967e170
to
2f986c8
Compare
@erikarvstedt Thanks. Updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2f986c8
bitcoin: 27.1 -> 28.0
bitcoind: 27.1 -> 28.0
clboss: 0.13.3 -> 0.14.0