Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nixpkgs #744

Merged
merged 2 commits into from
Nov 16, 2024
Merged

update nixpkgs #744

merged 2 commits into from
Nov 16, 2024

Conversation

jonasnick
Copy link
Member

bitcoin: 27.1 -> 28.0
bitcoind: 27.1 -> 28.0
clboss: 0.13.3 -> 0.14.0

Copy link
Contributor

@0xB10C 0xB10C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 967e170. The updates and LND config change seem reasonable to me.

Copy link
Collaborator

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did review this PR right after it was created. I noticed that test trustedcoin is consistently failing due to a timeout at this step:

machine: waiting for success: journalctl -b --output=cat -u clightning --grep='plugin-trustedcoin[^^]\[0m\s+bitcoind RPC working'

Will look into this soon.

@jonasnick
Copy link
Member Author

Oh, thanks @erikarvstedt. Good catch.

@VzxPLnHqr
Copy link

So far using bitcoind v28.0 and LND via this PR branch has given me no issues.

@erikarvstedt
Copy link
Collaborator

Blocked by nbd-wtf/trustedcoin#33

@erikarvstedt
Copy link
Collaborator

Fixed branch with trustedcoin update.

@jonasnick
Copy link
Member Author

@erikarvstedt Thanks! The trustedcoin test still fails for me due a time out at

vm-test-run-nix-bitcoin-trustedcoin> machine: waiting for success: journalctl -b --output=cat -u clightning --grep='plugin-trustedcoin[^^]\[0m\s+estimatefees error: none of the esploras returned usable responses'

erikarvstedt and others added 2 commits November 15, 2024 19:37
Supports bitcoind 28.0.
bitcoin: 27.1 -> 28.0
bitcoind: 27.1 -> 28.0
clboss: 0.13.3 -> 0.14.0
@erikarvstedt
Copy link
Collaborator

Thanks, fixed my branch.

@jonasnick
Copy link
Member Author

@erikarvstedt Thanks. Updated the PR.

Copy link
Collaborator

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2f986c8

@jonasnick jonasnick merged commit c0994bf into fort-nix:master Nov 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants