Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chain id to docker metrics #852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dkeysil
Copy link
Contributor

@dkeysil dkeysil commented Feb 13, 2024

We forgot to add chain id to some of the metrics so this PR fixes it

@dkeysil
Copy link
Contributor Author

dkeysil commented Feb 13, 2024

Can't figure out how we can find agent chain id for event metrics
https://github.com/forta-network/forta-node/blob/master/services/components/metrics/metrics.go#L45-L53

Probably we need to have registry instance in AgentMetricsAggregator - https://github.com/forta-network/forta-node/blob/master/services/publisher/metrics.go#L92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant