Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Early AD - True Positive list fetching #655

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Early AD - True Positive list fetching #655

wants to merge 21 commits into from

Conversation

RCantu92
Copy link
Contributor

@RCantu92 RCantu92 commented Jun 3, 2024 •
edited
Loading

Adding logic for the Early Attack Detector to be able to query for True Positive that have been identified

25 June edit: Changes deployed to Early Attack Detector Beta, but not merged to main because not deployed to PROD Early Attack Detector.

@RCantu92 RCantu92 self-assigned this Jun 4, 2024
@RCantu92 RCantu92 marked this pull request as ready for review June 4, 2024 22:15
@Vxatz Vxatz requested review from salort-forta and Vxatz June 5, 2024 08:27
Vxatz
Vxatz requested changes Jun 5, 2024
View reviewed changes
early-attack-detector-py/src/utils.py Outdated Show resolved Hide resolved
early-attack-detector-py/src/utils.py Outdated Show resolved Hide resolved
early-attack-detector-py/src/agent.py Outdated Show resolved Hide resolved
early-attack-detector-py/src/agent.py Outdated Show resolved Hide resolved
early-attack-detector-py/src/constants.py Outdated Show resolved Hide resolved
@RCantu92 RCantu92 requested a review from Vxatz June 11, 2024 22:53
Vxatz
Vxatz requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Vxatz Vxatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes, the only crucial is the one in the handle_alert

early-attack-detector-py/src/utils.py Outdated Show resolved Hide resolved
early-attack-detector-py/src/agent.py Outdated Show resolved Hide resolved
early-attack-detector-py/src/agent.py Outdated Show resolved Hide resolved
early-attack-detector-py/src/agent.py Outdated Show resolved Hide resolved
early-attack-detector-py/src/agent.py Outdated Show resolved Hide resolved
@RCantu92 RCantu92 requested a review from Vxatz June 14, 2024 16:27
Vxatz
Vxatz approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@Vxatz Vxatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RCantu92 RCantu92 mentioned this pull request Aug 15, 2024
Open
Vxatz
Vxatz requested changes Aug 16, 2024
View reviewed changes
early-attack-detector-py/src/findings.py Outdated Show resolved Hide resolved
early-attack-detector-py/src/utils.py Outdated Show resolved Hide resolved
@Vxatz Vxatz self-requested a review August 22, 2024 21:19
Vxatz
Vxatz approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@Vxatz Vxatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salort-forta salort-forta salort-forta left review comments

@Vxatz Vxatz Vxatz approved these changes

Assignees

@RCantu92 RCantu92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RCantu92 @Vxatz @salort-forta