Merge pull request #33 from fortanix/mkrause/241119-linter-fixes

[WIP] Fix biome linter errors
fortanix · Nov 20, 2024 · bb25bf3 · bb25bf3
2 parents 3301760 + 3fb2a0c
commit bb25bf3
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 12 deletions.
diff --git a/src/components/actions/Link/Link.stories.tsx b/src/components/actions/Link/Link.stories.tsx
@@ -45,7 +45,7 @@ export const Descenders: Story = {
 export const Scroll: Story = {
   render: (args) => (
     <>
-      <a id="anchor"></a>
+      <a id="anchor" href="/" onClick={evt => { evt.preventDefault(); }}>Anchor</a>
       <OverflowTester openDefault/>
       <Link {...args} href="#anchor"/>
       <OverflowTester openDefault/>

diff --git a/src/components/containers/Alert/Alert.stories.tsx b/src/components/containers/Alert/Alert.stories.tsx
@@ -31,10 +31,10 @@ export default {
 
 export const Standard: Story = {};
 
-export const Info: Story = { args: { kind: 'info' } };
-export const Warning: Story = { args: { kind: 'warning' } };
-export const Error: Story = { args: { kind: 'error' } };
-export const Success: Story = { args: { kind: 'success' } };
+export const InfoAlert: Story = { args: { kind: 'info' } };
+export const WarningAlert: Story = { args: { kind: 'warning' } };
+export const ErrorAlert: Story = { args: { kind: 'error' } };
+export const SuccessAlert: Story = { args: { kind: 'success' } };
 
 /** Multiple alerts stacked. */
 export const Stacked: Story = {

diff --git a/src/components/forms/context/SubmitButton/SubmitButton.tsx b/src/components/forms/context/SubmitButton/SubmitButton.tsx
@@ -45,13 +45,13 @@ export const SubmitButton = (props: SubmitButtonProps) => {
   const isDisabled = !isInteractive;
   const isNonactive = propsButton.nonactive || isPending;
 
-  const handlePress = () => {
+  const handlePress = React.useCallback(() => {
     if (typeof onPress !== 'function') { return; }
 
     startPressTransition(async () => {
       await Promise.race([onPress(), timeout(asyncTimeout)]);
     });
-  };
+  }, [onPress, asyncTimeout]);
 
   const handleClick = React.useCallback(async (event: React.MouseEvent<HTMLButtonElement, MouseEvent>) => {
     // `onClick` should not be used in most cases, only if the consumer needs low level control over click events.

diff --git a/src/components/forms/controls/SegmentedControl/SegmentedControl.tsx b/src/components/forms/controls/SegmentedControl/SegmentedControl.tsx
@@ -83,7 +83,8 @@ export const SegmentedControl = (props: SegmentedControlProps) => {
         [cl['bk-segmented-control--disabled']]: disabled,
       }, propsRest.className)}
     >
-      {formattedOptions.map((option, index) => 
+      {formattedOptions.map((option, index) =>
+        // biome-ignore lint/suspicious/noArrayIndexKey: no other unique identifier available
         <li key={index} className={cl['bk-segmented-control__item']}>
           <Button
             role="tab"

diff --git a/src/components/overlays/Modal/Modal.tsx b/src/components/overlays/Modal/Modal.tsx
@@ -161,7 +161,6 @@ const Modal = ({
   };
 
   return (
-    // biome-ignore lint/a11y/useKeyWithClickEvents: <explanation>
     <dialog
       ref={dialogRef}
       className={cx(

diff --git a/src/components/overlays/Toast/Toast.stories.tsx b/src/components/overlays/Toast/Toast.stories.tsx
@@ -49,7 +49,7 @@ const Actions = () => {
   );
 };
 
-export const Success: Story = {
+export const SuccessToast: Story = {
   args: {
     options: {},
   },
@@ -60,7 +60,7 @@ export const Success: Story = {
   ),
 };
 
-export const Info: Story = {
+export const InfoToast: Story = {
   args: {
     options: {},
   },
@@ -71,7 +71,7 @@ export const Info: Story = {
   ),
 };
 
-export const Error: Story = {
+export const ErrorToast: Story = {
   args: {
     options: {},
   },

diff --git a/src/util/storybook/OverflowTester.tsx b/src/util/storybook/OverflowTester.tsx
@@ -13,6 +13,8 @@ type OverflowTesterProps = {
 };
 export const OverflowTester = ({ lines = 50, openDefault = false }: OverflowTesterProps) => {
   const ref = React.useRef<HTMLDetailsElement>(null);
+
+  // biome-ignore lint/correctness/useExhaustiveDependencies: `openDefault` only applies on mount
   React.useEffect(() => {
     if (openDefault && ref.current) {
       ref.current.open = true;
@@ -23,6 +25,7 @@ export const OverflowTester = ({ lines = 50, openDefault = false }: OverflowTest
     <details ref={ref} className="util-overflow-tester">
       <summary>Test overflow</summary>
       {Array.from({ length: lines }).map((_, index) =>
+        // biome-ignore lint/suspicious/noArrayIndexKey: no other unique identifier available
         <p key={index}>...</p>
       )}
     </details>