-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update icons #54
Update icons #54
Conversation
mkrause
commented
Dec 10, 2024
- Update icons as per latest Figma export
- Remove now unnecessary renames/skips
TODO:
|
497deed
to
e24377c
Compare
Close buttons (cross) are considerably smaller than before, not sure if that's expected https://www.chromatic.com/test?appId=6757628e1f35f97b959b83b4&id=675b7da316bc53f4294facde |
It's expected yeah, I had discussed this with Leif. There are three variants (small, medium, large) of the cross icon in the Figma and we went for the middle one. Whether that's the right size I'm not sure, the whole icon pack really needs some work to get everything visually similar sized. |
@nighto It's a good catch though because this affects some components that are currently expecting the cross icon to be a certain size. I'll go through and review those components. |