Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons #54

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Update icons #54

merged 10 commits into from
Dec 17, 2024

Conversation

mkrause
Copy link
Collaborator

@mkrause mkrause commented Dec 10, 2024

  • Update icons as per latest Figma export
  • Remove now unnecessary renames/skips

@mkrause mkrause self-assigned this Dec 10, 2024
@mkrause
Copy link
Collaborator Author

mkrause commented Dec 10, 2024

TODO:

  • Fix a few more naming issues in the source icons
  • Add missing graphics (and add those to the relevant places, like PlaceholderEmpty)
  • Add a check in the import script that all icons are the same size (currently: 18x18)
  • Check accessibility requirements: add ARIA attributes to each icon?

@mkrause mkrause force-pushed the mkrause/241210-update-icons branch from 497deed to e24377c Compare December 12, 2024 23:18
@mkrause mkrause marked this pull request as ready for review December 13, 2024 00:18
@nighto
Copy link
Collaborator

nighto commented Dec 13, 2024

Close buttons (cross) are considerably smaller than before, not sure if that's expected https://www.chromatic.com/test?appId=6757628e1f35f97b959b83b4&id=675b7da316bc53f4294facde

@mkrause
Copy link
Collaborator Author

mkrause commented Dec 13, 2024

Close buttons (cross) are considerably smaller than before, not sure if that's expected https://www.chromatic.com/test?appId=6757628e1f35f97b959b83b4&id=675b7da316bc53f4294facde

It's expected yeah, I had discussed this with Leif. There are three variants (small, medium, large) of the cross icon in the Figma and we went for the middle one. Whether that's the right size I'm not sure, the whole icon pack really needs some work to get everything visually similar sized.

@mkrause
Copy link
Collaborator Author

mkrause commented Dec 13, 2024

@nighto It's a good catch though because this affects some components that are currently expecting the cross icon to be a certain size. I'll go through and review those components.

@mkrause mkrause requested a review from nighto December 14, 2024 14:34
@mkrause mkrause merged commit 790f1d5 into master Dec 17, 2024
3 checks passed
@mkrause mkrause deleted the mkrause/241210-update-icons branch December 17, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants